Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4413 - Bootdisk images UEFI compatible #64

Closed
wants to merge 1 commit into from

Conversation

dforsberg
Copy link

@dforsberg dforsberg commented Jun 21, 2018

This is a new version of @lzap PR #62

This uses the grub2 files for foreman-bootloaders-tftpboot located in /var/lib/tftpboot/grub2.
Supports EFI boot of older operating systems like RHEL6, use linux and initrd command in the PXEGrub2 template for those.

If there is no PXEGrub2 template assigned to the operating system it will only give a warning in the log file. PXEGrub templates are not assigned to operating systems by default and is not required.

TODO:
Patch for ipxe.efi to read cmdline options: https://bugzilla.redhat.com/show_bug.cgi?id=1401491
Needs a selinux change to work:

module satellite-efi-bootdisk 1.0;

require {
        type passenger_t;
        type tftpdir_rw_t;
        class file { getattr ioctl open read };
        class dir search;
}

#============= passenger_t ==============
allow passenger_t tftpdir_rw_t:file { getattr ioctl open read };
allow passenger_t tftpdir_rw_t:dir search;

Compile this to a selinux package and install it:

checkmodule -M -m -o satellite-efi-bootdisk.mod satellite-efi-bootdisk.te
semodule_package -o satellite-efi-bootdisk.pp -m satellite-efi-bootdisk.mod
semodule -i satellite-efi-bootdisk.pp

@theforeman-bot
Copy link
Member

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! Comments inline.

Plus can you make README change updating the table - what's supported and what not. Make a note about iPXE UEFI patch required to have it working.

@lzap
Copy link
Member

lzap commented Oct 3, 2018

Hello? Any updates?

@lzap
Copy link
Member

lzap commented Apr 3, 2020

I am going to resurrect this patch, it looks like in UEFI environment Grub2 can do HTTP just fine, few fixes has been merged into Fedora Rawhide recently so this enables us to remove iPXE from the UEFI workflow completely and just rely on Grub2. I will update the changes accordingly and make a new PR.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants