Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace alias_method_chain with Module.prepend #15

Merged
merged 1 commit into from Oct 7, 2018

Conversation

Projects
None yet
4 participants
@timogoebel
Copy link
Member

commented Nov 1, 2017

This plugin conflicts with foreman_monitoring (see theforeman/foreman_monitoring#30) because it still uses alias_method_chain. This PR replaces the deprecated alias_method_chain with Module.prepend.

@dgoetz

This comment has been minimized.

Copy link
Member

commented Jul 5, 2018

@dLobatog Can you merge this, please? Foreman 1.17 with other plugins installed which use alias_method_chain or Module.prepend it will cause the Cockpit button to not show up, with the patch applied it works fine.

@tbrisker

This comment has been minimized.

Copy link
Member

commented Oct 7, 2018

Merging this, someone will need to take care of the plugin to release a newer version containing it.

@tbrisker tbrisker merged commit 6ac4cc9 into theforeman:master Oct 7, 2018

1 check passed

codeclimate All good!
Details
@paulcalabro

This comment has been minimized.

Copy link

commented Oct 26, 2018

Awesome, I can confirm this fixed my issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.