New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16528 - Added foreign key dependency #307

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
3 participants
@amitkarsale

amitkarsale commented Oct 6, 2016

In foreman db, there is a missing key constraint from subnet.discovery_id to smart_proxies.id. That means, if a subnet refers a Discovery Capsule and I delete the capsule/proxy, no warning is raised.

Add a key constraint similar to e.g. "subnet.tftp_id -> smart_proxies.id".

@amitkarsale amitkarsale changed the title from #16528 - Subnet's Discovery Capsule can point to a deleted proxy to Fixes #16528 - Subnet's Discovery Capsule can point to a deleted proxy Oct 6, 2016

@lzap

This comment has been minimized.

Show comment
Hide comment
@lzap

lzap Oct 11, 2016

Member

Thanks. Can you fix the indentation?

Member

lzap commented Oct 11, 2016

Thanks. Can you fix the indentation?

@amitkarsale amitkarsale changed the title from Fixes #16528 - Subnet's Discovery Capsule can point to a deleted proxy to Fixes #16528 - Added foreign key dependency Oct 12, 2016

@amitkarsale

This comment has been minimized.

Show comment
Hide comment
@amitkarsale

amitkarsale Oct 12, 2016

@lzap , done the necessary indentation.

amitkarsale commented Oct 12, 2016

@lzap , done the necessary indentation.

@lzap lzap merged commit 514576e into theforeman:develop Oct 12, 2016

1 check was pending

default You're not in the automated testing whitelist. Please contact us at #theforeman-dev to have this pull request manually tested.
Details
@lzap

This comment has been minimized.

Show comment
Hide comment
@lzap

lzap Oct 12, 2016

Member

Thank you for the contribution @amitkarsale !

Member

lzap commented Oct 12, 2016

Thank you for the contribution @amitkarsale !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment