Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30911 - Fix issue with selecting host ids for Upgrade Button #102

Merged
merged 2 commits into from Sep 25, 2020
Merged

Fixes #30911 - Fix issue with selecting host ids for Upgrade Button #102

merged 2 commits into from Sep 25, 2020

Conversation

stejskalleos
Copy link
Contributor

How to reproduce issue

  • Preupgrade job without any items that can be fixed by Leapp tool (without commands)
  • At Leapp preupgrade report tab, click on Run Upgrade button

After redirect Search Query on Job invocation form is empty.

Fix
Not using idsForInvocationFromReports.

@xprazak2
Copy link
Contributor

Works as expected. Linting issues unrelated, though github will not allow me to merge without required check.

@stejskalleos, could you rename props to componentProps on lines 113, 114, 129 in PreupgradeReports.js please? That should make the lint green.

@stejskalleos
Copy link
Contributor Author

lint issues fixed.
@adamruzicka If you okay with PR we can merge & I'll release new pkg version ASAP.

adamruzicka
adamruzicka approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, ACK

@adamruzicka adamruzicka merged commit a9be41b into theforeman:master Sep 25, 2020
@adamruzicka
Copy link
Contributor

Thank you @stejskalleos & @xprazak2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stejskalleos @xprazak2 @adamruzicka