Adding react #32

amirfefer · 2020-04-23T14:42:52Z

Adding Example Component
Adding Foreman metapackages (test, lint, storybook, vendor)
Adding React Router
Adding Redux infra & usage
Adding Slot&Fill infra
Adding API usage via APIMiddleware
Adding React Router interface from foreman

package.json

webpack/src/Components/EmptyState/EmptyPage.scss

webpack/src/PluginName.js

xprazak2 · 2020-04-23T16:19:54Z

Nice work! Should the rename script process the js files as well in some way?

package.json

amirfefer · 2020-05-04T01:29:45Z

Thanks @xprazak2 ! ready for another review :)

app/views/foreman_plugin_template/layouts/react.html.erb

xprazak2 · 2020-05-04T06:03:57Z

app/views/foreman_plugin_template/layouts/react.html.erb

+
+<% content_for(:content) do %>
+  <%= notifications %>
+  <div id="organization-id" data-id="<%= Organization.current.id if Organization.current %>" ></div>


Should ForemanContext be used instead?

Sounds like a nice to have 👍 , but it needs another PR in foreman-core for adding taxonomies into app_metadata

I've added taxonomies and user_id to the app_metadata here - theforeman/foreman#7655

xprazak2 · 2020-05-04T06:04:53Z

Nice progress, should Gemfile.lock be included if it is in gitignore?

amirfefer · 2020-05-07T00:22:50Z

Adding permissions for react views
Verifying that the react page renders as expected
Adding more react-hooks usage

tbrisker · 2020-05-10T12:08:31Z

app/controllers/foreman_plugin_template/react_controller.rb

@@ -0,0 +1,17 @@
+module ForemanPluginTemplate
+  class ReactController < ::ApplicationController


Should plugins reuse the ReactController and react layout from core?

When the react router for plugins will be ready in foreman-core, the core's react layout and controller will be reusable, until then we still need to mount plugin's root component via plugin's react layout.

# plugin/layout/react mount_react_component('PluginTemplate', '#foremanPluginTemplateRoot')

So can we drop this now?

tbrisker

a couple of small comments inline, other than that lgtm.

tbrisker · 2020-05-11T06:31:58Z

lib/foreman_plugin_template/engine.rb

@@ -18,9 +18,13 @@ class Engine < ::Rails::Engine
      Foreman::Plugin.register :foreman_plugin_template do
        requires_foreman '>= 1.16'

+        # Add Global JS file for extending foreman-core components and routes
+        register_global_js_file 'fills'


the file is named fills_index.js, so i think this needs to change

the _index suffix is added automatically.

tbrisker · 2020-05-11T06:32:53Z

lib/foreman_plugin_template/engine.rb

@@ -18,9 +18,13 @@ class Engine < ::Rails::Engine
      Foreman::Plugin.register :foreman_plugin_template do
        requires_foreman '>= 1.16'


This should be the first version that matches what is in the package.json

Ron-Lavi

Thanks @amirfefer it's great to see this PR, looks good!
added some suggestions

Ron-Lavi · 2020-05-11T13:17:07Z

app/controllers/foreman_plugin_template/react_controller.rb

+module ForemanPluginTemplate
+  class ReactController < ::ApplicationController
+    def index
+      render 'foreman_plugin_template/layouts/react', :layout => false


can you instead add a default layout in app/views/layout/foreman_plugin_template/application.html.erb
and than set it on line 3 as the default layout: layout "foreman_plugin_template/application"

this will reduce the need to call the render method on each action as it will automatically render app/views/foreman_plugin_template/react/index.html.erb

Ron-Lavi · 2020-05-11T13:24:26Z

package.json

+    "test:current": "tfm-test --plugin --watch",
+    "publish-coverage": "tfm-publish-coverage",
+    "stories": "tfm-stories --plugin",
+    "stories:build": "tfm-build-stories --plugin",


do we also want stories:deploy to surge?

I think that the storybook deployment should stay consumer's choice

true, but we can make it all set for them and they can decide to remove it or not,
I don't think it's too painful to have :)

Ron-Lavi · 2020-05-11T13:27:13Z

webpack/index.js

+import componentRegistry from 'foremanReact/components/componentRegistry';
+import { registerReducer } from 'foremanReact/common/MountingService';
+import reducers from './src/reducers';
+import PluginTemplate from './src/PluginName';


should PluginName folder be renamed to ForemanPluginTemplate ?

Ron-Lavi · 2020-05-11T13:29:35Z

webpack/index.js

+// register components for erb mounting
+componentRegistry.register({
+  name: 'PluginTemplate',
+  type: PluginTemplate,
+});


can you create another component file that contains pairs of { name, type }
and here make a forEach loop, same as the reducers are being registered

doesn't it overkill for a very small amount of reducers? , also the reducer registering might be unclear for newcomers?

I think that the registries will be very easy to use, as they won't even need to touch this file
and just put all of their component in one spot without calling each time componentRegistry.register()

Ron-Lavi · 2020-05-11T13:31:23Z

webpack/src/Components/EmptyState/Constants.js

@@ -0,0 +1,2 @@
+export const ADD_CONTENT = '[PLUGIN_TEMPLATE] ADD_CONTENT';


will the name be replaced with a script?
after it will be replaced we should keep on the underline convention.

It is written in a way to make it clear for renaming, in redux console it would bold enough like that IMHO.

yes, but can it be done automatically with the rename.rb?
can you also rename this file into EmptyStateConstants.js

what do you think @amirfefer ?

Ron-Lavi · 2020-05-11T13:38:32Z

webpack/src/Components/EmptyState/EmptyStateActions.js

+
+export const AddEmptyStateContent = header => ({
+  type: ADD_CONTENT,
+  payload: header,


I believe the payload should be wrapped by an object

not it this case, the payload is just a string, it's a very simple action

IMO we should create another example, maybe something with the empty state button click which creates an API call that passes some data to the page,

passing the header feels like something that doesn't happen much.

Ron-Lavi · 2020-05-11T13:41:41Z

webpack/src/Components/EmptyState/EmptyStateActions.js

+export const fetchData = url => ({
+  type: API_OPERATIONS.GET,
+  key: FETCHING_KEY, // you will need to re-use this key in order to access the right API reducer later.
+  url,
+  payload: {},
+});


instead you can use the get helper from Foreman, e.g:

import { get } from 'foremanReact/redux/API'; get({ key, url })

Thanks, added

Ron-Lavi · 2020-05-11T13:42:04Z

webpack/src/Components/EmptyState/EmptyStateReducer.js

+  switch (action.type) {
+    case ADD_CONTENT:
+      return state.set('header', payload);
+


nit: extra line

our linter allows this kind of spacing

Ron-Lavi · 2020-05-11T13:43:46Z

webpack/src/PluginName.js

@@ -0,0 +1,11 @@
+import React from 'react';
+import { BrowserRouter } from 'react-router-dom';
+import PluginTemplateRoute from './Route';


should we rename Route to Router?

Ron-Lavi · 2020-05-11T13:45:03Z

webpack/src/Route/routes.js

+  welcome: {
+    path: '/foreman_plugin_template',
+    exact: true,
+    render: () => <WelcomPage />,


should we use component instead of render in this cases?

amirfefer · 2020-05-13T15:59:34Z

Thanks @LaViro for your review!
I've addressed most of your requests

ezr-ondrej

Testing it today/tomorrow, I'll add what I find :)

ezr-ondrej · 2020-05-17T11:38:51Z

webpack/src/Router/routes.js

@@ -0,0 +1,11 @@
+import WelcomPage from './WelcomePage';


Suggested change

import WelcomPage from './WelcomePage';

import WelcomePage from './WelcomePage';

ezr-ondrej · 2020-05-17T11:38:59Z

webpack/src/Router/routes.js

+  welcome: {
+    path: '/foreman_plugin_template',
+    exact: true,
+    component: WelcomPage,


Suggested change

component: WelcomPage,

component: WelcomePage,

ezr-ondrej · 2020-05-18T10:02:11Z

foreman_plugin_template.gemspec

-  s.authors     = ['TODO: Your name']
-  s.email       = ['TODO: Your email']
-  s.homepage    = 'TODO'
-  s.summary     = 'TODO: Summary of ForemanPluginTemplate.'
+  s.authors     = [' Your name']
+  s.email       = [' Your email']
+  s.homepage    = ''
+  s.summary     = ' Summary of ForemanPluginTemplate.'


What is the reason for this? 🤔

for testing with foreman core, forgot to delete it :(

ezr-ondrej

Bunch of places need Foreman prefix to get picked up by ./rename.rb
Also rename.rb needs line system(%(sed 's/foremanPluginTemplate/#{camel_lower}/g' #{tmp_file} > #{path}))

ezr-ondrej · 2020-05-18T10:04:46Z

package.json

@@ -0,0 +1,42 @@
+{
+  "name": "plugin-name",


this is not picked up by rename.rb

Suggested change

"name": "plugin-name",

"name": "foreman_plugin_template",

ezr-ondrej · 2020-05-18T10:05:52Z

webpack/index.js

+import componentRegistry from 'foremanReact/components/componentRegistry';
+import { registerReducer } from 'foremanReact/common/MountingService';
+import reducers from './src/reducers';
+import PluginTemplate from './src/PluginTemplate';


Suggested change

import PluginTemplate from './src/PluginTemplate';

import ForemanPluginTemplate from './src/ForemanPluginTemplate';

ezr-ondrej · 2020-05-18T10:06:10Z

webpack/index.js

+  name: 'PluginTemplate',
+  type: PluginTemplate,


Suggested change

name: 'PluginTemplate',

type: PluginTemplate,

name: 'ForemanPluginTemplate',

type: ForemanPluginTemplate,

ezr-ondrej · 2020-05-18T10:07:15Z

webpack/src/PluginTemplate.js

@@ -0,0 +1,11 @@
+import React from 'react';
+import { BrowserRouter } from 'react-router-dom';
+import PluginTemplateRoute from './Router';


Suggested change

import PluginTemplateRoute from './Router';

import ForemanPluginTemplateRoute from './Router';

ezr-ondrej · 2020-05-18T10:07:27Z

webpack/src/PluginTemplate.js

+import { BrowserRouter } from 'react-router-dom';
+import PluginTemplateRoute from './Router';
+
+const PluginTemplate = () => (


Suggested change

const PluginTemplate = () => (

const ForemanPluginTemplate = () => (

ezr-ondrej · 2020-05-18T10:07:39Z

webpack/src/PluginTemplate.js

+
+const PluginTemplate = () => (
+  <BrowserRouter>
+    <PluginTemplateRoute />


Suggested change

<PluginTemplateRoute />

<ForemanPluginTemplateRoute />

ezr-ondrej · 2020-05-18T10:07:51Z

webpack/src/PluginTemplate.js

+  </BrowserRouter>
+);
+
+export default PluginTemplate;


Suggested change

export default PluginTemplate;

export default ForemanPluginTemplate;

ezr-ondrej · 2020-05-18T10:08:51Z

webpack/src/index.js

@@ -0,0 +1 @@
+export { default } from './PluginName';


Suggested change

export { default } from './PluginName';

export { default } from './ForemanPluginName';

Also the file needs renaming :)

ezr-ondrej · 2020-05-18T10:09:09Z

webpack/src/reducers.js

+import EmptyStateReducer from './Components/EmptyState/EmptyStateReducer';
+
+const reducers = {
+  pluginTemplate: combineReducers({


Suggested change

pluginTemplate: combineReducers({

foremanPluginTemplate: combineReducers({

ezr-ondrej · 2020-05-18T10:45:59Z

app/views/foreman_plugin_template/layouts/application_react.html.erb

+  <div id="foremanPluginTemplateRoot"></div>
+<% end %>
+<%= render file: "layouts/base" %>
+<%= mount_react_component('PluginTemplate', '#foremanPluginTemplateRoot') %>


Suggested change

<%= mount_react_component('PluginTemplate', '#foremanPluginTemplateRoot') %>

<%= mount_react_component('ForemanPluginTemplate', '#foremanPluginTemplateRoot') %>

ezr-ondrej · 2020-05-18T10:47:19Z

webpack/src/Router/routes.test.js

+
+import Routes from './routes';
+
+describe('PluginTemplateRoutes', () => {


Suggested change

describe('PluginTemplateRoutes', () => {

describe('ForemanPluginTemplateRoutes', () => {

ezr-ondrej · 2020-05-18T14:29:56Z

webpack/src/Router/routes.test.js

+describe('PluginTemplateRoutes', () => {
+  it('should create routes', () => {
+    Object.entries(Routes).forEach(([key, Route]) => {
+      const component = shallow(<Route.render history={{}} some="props" />);


Suggested change

const component = shallow(<Route.render history={{}} some="props" />);

const component = shallow(<Route.component history={{}} some="props" />);

amirfefer · 2020-05-24T23:29:06Z

Thanks @ezr-ondrej, I have updated the rename.rb

Ron-Lavi

Awesome work @amirfefer !
Left a few comments,
can you add more tests ?
can you also add .travis.yml file?

Ron-Lavi · 2020-05-28T09:58:37Z

webpack/__mocks__/foremanReact/readme.md

+ForemanModal.Header = () => jest.fn();
+ForemanModal.Footer = () => jest.fn();
+export default ForemanModal;
+```


Looks like this file is accidentally called readme.md

can you rename the file?

Ron-Lavi · 2020-05-28T10:00:26Z

webpack/src/Components/EmptyState/Constants.js

@@ -0,0 +1,2 @@
+export const ADD_CONTENT = '[PLUGIN_TEMPLATE] ADD_CONTENT';


yes, but can it be done automatically with the rename.rb?
can you also rename this file into EmptyStateConstants.js

Ron-Lavi · 2020-05-28T10:03:57Z

webpack/src/Components/EmptyState/EmptyPageSelectors.js

@@ -0,0 +1,2 @@
+const selectEmptyState = state => state.foremanPluginTemplate.emptyState;
+export const selectEmptyStateHeader = state => selectEmptyState(state).header;


can you add selector tests?

Ron-Lavi · 2020-05-28T10:05:44Z

webpack/src/Components/EmptyState/EmptyState.js

+  const header = useSelector(selectEmptyStateHeader);
+
+  useEffect(() => {
+    dispatch(AddEmptyStateHeader(__('Foreman Plugin Template - React Page')));


can you add an index.js file where it will trigger the action
while passing only the header prop into this component?

Ron-Lavi · 2020-05-28T10:06:54Z

webpack/src/Components/EmptyState/EmptyStateActions.js

+  url,
+  payload: {},
+});
+


can you add tests to the actions?

Ron-Lavi · 2020-05-28T10:07:33Z

webpack/src/Components/EmptyState/EmptyStateReducer.js

+export default (state = initialState, action) => {
+  const { payload } = action;
+
+  switch (action.type) {


can you destruct also type ?

and can we also add a test for the reducer?

Ron-Lavi · 2020-05-28T10:10:42Z

webpack/src/ForemanPluginTemplate.js

+const PluginTemplate = () => (
+  <BrowserRouter>
+    <PluginTemplateRoute />
+  </BrowserRouter>


can you also add react-intl?

Ron-Lavi · 2020-05-28T10:13:29Z

package.json

+  "devDependencies": {
+    "@babel/core": "^7.7.0",
+    "@theforeman/builder": "^4.0.2",
+    "@theforeman/eslint-plugin-foreman": "4.0.5",


can you align all of @theforeman/packages to have the same version?

can you also upgrade to 4.8.0 version of @theforeman packages?

rabajaj0509 · 2020-06-11T17:58:22Z

.stylelintrc

@@ -0,0 +1,6 @@
+


nit: extra space

rabajaj0509 · 2020-06-11T18:07:28Z

babel.config.js

@@ -0,0 +1,3 @@
+module.exports = {


nit: can we do something like:

export const presets = ["@theforeman/builder/babel"];

ezr-ondrej

Could you please change the naming so the rename picks it up and fix the endlines?
I belive the tests would be nice to have, but can be as a followup PR, so if you fix followings, I'd be ok to merge.
@LaViro do you have any blocking comments?

ezr-ondrej · 2020-06-18T21:17:42Z

webpack/src/ForemanPluginTemplate.js

@@ -0,0 +1,11 @@
+import React from 'react';
+import { BrowserRouter } from 'react-router-dom';
+import PluginTemplateRoute from './Router';


Suggested change

import PluginTemplateRoute from './Router';

import ForemanPluginTemplateRoute from './Router';

ezr-ondrej · 2020-06-18T21:17:50Z

webpack/src/ForemanPluginTemplate.js

+import { BrowserRouter } from 'react-router-dom';
+import PluginTemplateRoute from './Router';
+
+const PluginTemplate = () => (


Suggested change

const PluginTemplate = () => (

const ForemanPluginTemplate = () => (

ezr-ondrej · 2020-06-18T21:18:00Z

webpack/src/ForemanPluginTemplate.js

+
+const PluginTemplate = () => (
+  <BrowserRouter>
+    <PluginTemplateRoute />


Suggested change

<PluginTemplateRoute />

<ForemanPluginTemplateRoute />

ezr-ondrej · 2020-06-18T21:18:08Z

webpack/src/ForemanPluginTemplate.js

+  </BrowserRouter>
+);
+
+export default PluginTemplate;


Suggested change

export default PluginTemplate;

export default ForemanPluginTemplate;

ezr-ondrej · 2020-06-18T21:18:37Z

.gitignore

+node_modules
+package-lock.json
+Gemfile.lock
+coverage


missing endline

ezr-ondrej · 2020-06-18T21:18:45Z

.stylelintrc

+  "extends": [
+    "stylelint-config-standard",
+  ],
+}


missing endline

ezr-ondrej · 2020-06-18T21:36:59Z

webpack/fills_index.js

@@ -0,0 +1,15 @@
+// This example for extanding foreman-core's component via slot&fill


Suggested change

// This example for extanding foreman-core's component via slot&fill

// This is an example of extending foreman-core's component via slot&fill

Ron-Lavi

great work @amirfefer, are you waiting for something to be merged in core?
I still have some few unresolved suggestions from the last review,
added a few more comments, thanks!

Ron-Lavi · 2020-06-22T10:55:09Z

app/controllers/foreman_plugin_template/react_controller.rb

+    private
+
+    def controller_permission
+      :foreman_plugin_template


regarding permissions I think we should let the plugin owner to set the permissions as they are going to change anyway.. but the react layout doesn't need to change

Ron-Lavi · 2020-06-22T10:57:24Z

app/views/foreman_plugin_template/layouts/application_react.html.erb

+  <div id="foremanPluginTemplateRoot"></div>
+<% end %>
+<%= render file: "layouts/base" %>
+<%= mount_react_component('ForemanPluginTemplate', '#foremanPluginTemplateRoot') %>


can you use the react_component helper instead? you can remove the extra div from line 13

Ron-Lavi · 2020-06-22T11:08:32Z

config/routes.rb

@@ -1,3 +1,4 @@
 Rails.application.routes.draw do
  get 'new_action', to: 'foreman_plugin_template/hosts#new_action'
+  get 'foreman_plugin_template', to: 'foreman_plugin_template/react#index'


can you rename the route into "welcome_page"

Ron-Lavi · 2020-06-22T11:09:04Z

webpack/__mocks__/foremanReact/readme.md

+ForemanModal.Header = () => jest.fn();
+ForemanModal.Footer = () => jest.fn();
+export default ForemanModal;
+```


can you rename the file?

Ron-Lavi · 2020-06-22T11:10:53Z

webpack/src/Components/EmptyState/Constants.js

@@ -0,0 +1,2 @@
+export const ADD_CONTENT = '[PLUGIN_TEMPLATE] ADD_CONTENT';


what do you think @amirfefer ?

Ron-Lavi · 2020-06-22T11:11:37Z

webpack/src/Components/EmptyState/EmptyPage.test.js

+};
+
+describe('EmptyState', () =>
+  testComponentSnapshotsWithFixtures(EmptyState, fixtures));


can you move it to the __tests__ folder?

Ron-Lavi · 2020-06-22T11:14:47Z

package.json

+  "devDependencies": {
+    "@babel/core": "^7.7.0",
+    "@theforeman/builder": "^4.0.2",
+    "@theforeman/eslint-plugin-foreman": "4.0.5",


can you also upgrade to 4.8.0 version of @theforeman packages?

Ron-Lavi · 2020-06-22T11:15:54Z

webpack/src/ForemanPluginTemplate.js

@@ -0,0 +1,11 @@
+import React from 'react';
+import { BrowserRouter } from 'react-router-dom';


should we use the redux router that is now being added to core?

ezr-ondrej · 2020-07-13T00:43:10Z

We should add a webpack folder to the .gemspec file as theforeman/foreman_statistics#15 figured.

ekohl · 2020-07-14T10:00:11Z

webpack/src/Components/EmptyState/EmptyState.js

+      <PfEmptyState.Info>{description}</PfEmptyState.Info>
+      <PfEmptyState.Action>
+        <Button
+          href="https://theforeman.github.io/foreman"


Why does it link here? I'd always suggest to link to something like example.com in sample code.

ezr-ondrej · 2020-08-04T09:14:54Z

We should add a webpack folder to the .gemspec file as theforeman/foreman_statistics#15 figured.

webpack and package.json

ares · 2020-10-29T12:08:58Z

What's the status here?

ezr-ondrej · 2020-10-29T13:38:27Z

foreman_plugin_template.gemspec

+  s.authors     = 'a'
+  s.email       = ['a']
+  s.homepage    = 'http://a.com'
+  s.summary     = 'a'
  # also update locale/gemspec.rb
-  s.description = 'TODO: Description of ForemanPluginTemplate.'
+  s.description = 'a'


This should not change ^_^

ezr-ondrej

Can we merge the global files and drop the Plugins React controller? :)
I believe we should drop it, even if we would want some plugins to still use it, the template is for new plugins and we want to encourage the usage of the new router.

ezr-ondrej · 2020-10-29T13:39:05Z

lib/foreman_plugin_template/engine.rb

+
+        # Add Global files for extending foreman-core components and routes
+        register_global_js_file 'fills'
+        register_global_js_file 'routes'


Can we use one file for all of the plugin's global registrations?

ezr-ondrej · 2020-10-29T13:41:18Z

lib/foreman_plugin_template/engine.rb

@@ -16,11 +16,16 @@ class Engine < ::Rails::Engine

    initializer 'foreman_plugin_template.register_plugin', :before => :finisher_hook do |_app|
      Foreman::Plugin.register :foreman_plugin_template do
-        requires_foreman '>= 1.16'
+        requires_foreman '>= 2.0.0'


We will need to bump the version if we want to use the core router.

Suggested change

requires_foreman '>= 2.0.0'

requires_foreman '>= 2.3.0'

amirfefer · 2021-01-05T12:34:25Z

This PR has been refactored, due to the number of comments I'm closing this in favor of #35

xprazak2 reviewed Apr 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

xprazak2 reviewed Apr 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

xprazak2 reviewed Apr 23, 2020

View reviewed changes

webpack/src/Components/EmptyState/EmptyPage.scss Outdated Show resolved Hide resolved

xprazak2 reviewed Apr 23, 2020

View reviewed changes

webpack/src/PluginName.js Outdated Show resolved Hide resolved

xprazak2 reviewed Apr 23, 2020

View reviewed changes

webpack/src/PluginName.js Outdated Show resolved Hide resolved

ekohl reviewed Apr 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

amirfefer force-pushed the add_react branch 2 times, most recently from d29bed1 to f1d5f16 Compare May 4, 2020 01:25

amirfefer changed the title ~~[WIP] Adding react~~ Adding react May 4, 2020

xprazak2 reviewed May 4, 2020

View reviewed changes

app/views/foreman_plugin_template/layouts/react.html.erb Outdated Show resolved Hide resolved

xprazak2 reviewed May 4, 2020

View reviewed changes

amirfefer force-pushed the add_react branch from f1d5f16 to 21a5036 Compare May 7, 2020 00:20

tbrisker reviewed May 10, 2020

View reviewed changes

tbrisker reviewed May 11, 2020

View reviewed changes

Ron-Lavi reviewed May 11, 2020

View reviewed changes

amirfefer force-pushed the add_react branch from 21a5036 to c0306a5 Compare May 13, 2020 15:58

ezr-ondrej reviewed May 17, 2020

View reviewed changes

ezr-ondrej reviewed May 18, 2020

View reviewed changes

ezr-ondrej requested changes May 18, 2020

View reviewed changes

ezr-ondrej reviewed May 18, 2020

View reviewed changes

amirfefer force-pushed the add_react branch from c0306a5 to 8bc667a Compare May 24, 2020 23:27

Ron-Lavi reviewed May 28, 2020

View reviewed changes

xprazak2 mentioned this pull request May 29, 2020

Fixes #29903 - Add select functionality to table theforeman/foreman#7679

Merged

rabajaj0509 reviewed Jun 11, 2020

View reviewed changes

.stylelintrc Outdated

@@ -0,0 +1,6 @@

Copy link

Member

rabajaj0509 Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space

rabajaj0509 reviewed Jun 11, 2020

View reviewed changes

ezr-ondrej requested changes Jun 18, 2020

View reviewed changes

ezr-ondrej reviewed Jun 18, 2020

View reviewed changes

Ron-Lavi reviewed Jun 22, 2020

View reviewed changes

ekohl reviewed Jul 14, 2020

View reviewed changes

tbrisker added the waiting on contributor label Aug 4, 2020

amirfefer and others added 3 commits October 21, 2020 17:55

Adding react

4b558be

basic changes

06dc6a9

add react-router interface

b8855a2

amirfefer force-pushed the add_react branch from b16c512 to b8855a2 Compare October 21, 2020 18:14

amirfefer mentioned this pull request Oct 21, 2020

Fixes #27457 - Add support for react router in plugins theforeman/foreman#6936

Merged

ezr-ondrej reviewed Oct 29, 2020

View reviewed changes

ezr-ondrej requested changes Oct 29, 2020

View reviewed changes

amirfefer closed this Jan 5, 2021

ekohl deleted the add_react branch November 25, 2022 12:17

		@@ -0,0 +1,17 @@
		module ForemanPluginTemplate
		class ReactController < ::ApplicationController

		@@ -18,9 +18,13 @@ class Engine < ::Rails::Engine
		Foreman::Plugin.register :foreman_plugin_template do
		requires_foreman '>= 1.16'

		@@ -0,0 +1,2 @@
		export const ADD_CONTENT = '[PLUGIN_TEMPLATE] ADD_CONTENT';

	import WelcomPage from './WelcomePage';
	import WelcomePage from './WelcomePage';

	import PluginTemplate from './src/PluginTemplate';
	import ForemanPluginTemplate from './src/ForemanPluginTemplate';

	import PluginTemplateRoute from './Router';
	import ForemanPluginTemplateRoute from './Router';

	const PluginTemplate = () => (
	const ForemanPluginTemplate = () => (

	export default PluginTemplate;
	export default ForemanPluginTemplate;

	export { default } from './PluginName';
	export { default } from './ForemanPluginName';

	pluginTemplate: combineReducers({
	foremanPluginTemplate: combineReducers({

	<%= mount_react_component('PluginTemplate', '#foremanPluginTemplateRoot') %>
	<%= mount_react_component('ForemanPluginTemplate', '#foremanPluginTemplateRoot') %>


		import Routes from './routes';

		describe('PluginTemplateRoutes', () => {

	describe('PluginTemplateRoutes', () => {
	describe('ForemanPluginTemplateRoutes', () => {

	const component = shallow(<Route.render history={{}} some="props" />);
	const component = shallow(<Route.component history={{}} some="props" />);

		@@ -0,0 +1,2 @@
		const selectEmptyState = state => state.foremanPluginTemplate.emptyState;
		export const selectEmptyStateHeader = state => selectEmptyState(state).header;

		@@ -0,0 +1,15 @@
		// This example for extanding foreman-core's component via slot&fill

	// This example for extanding foreman-core's component via slot&fill
	// This is an example of extending foreman-core's component via slot&fill

		@@ -0,0 +1,11 @@
		import React from 'react';
		import { BrowserRouter } from 'react-router-dom';

Adding react #32

Adding react #32

Conversation

amirfefer commented Apr 23, 2020 • edited

xprazak2 commented Apr 23, 2020

amirfefer commented May 4, 2020

Choose a reason for hiding this comment

amirfefer May 7, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xprazak2 commented May 4, 2020

amirfefer commented May 7, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tbrisker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ron-Lavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer May 13, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer May 13, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer May 13, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer commented May 13, 2020 • edited

ezr-ondrej left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ezr-ondrej left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer commented May 24, 2020

Ron-Lavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirfefer commented Apr 23, 2020 •

edited

amirfefer May 7, 2020 •

edited

amirfefer commented May 7, 2020 •

edited

amirfefer May 13, 2020 •

edited

amirfefer May 13, 2020 •

edited

amirfefer May 13, 2020 •

edited

amirfefer commented May 13, 2020 •

edited