Drop only existing foreign_keys #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| remove_foreign_key 'host_classes', 'puppetclasses', name: 'host_classes_puppetclass_id_fk' | ||
| remove_foreign_key 'operatingsystems_puppetclasses', 'operatingsystems', name: 'operatingsystems_puppetclasses_operatingsystem_id_fk' | ||
| remove_foreign_key 'operatingsystems_puppetclasses', 'puppetclasses', name: 'operatingsystems_puppetclasses_puppetclass_id_fk' | ||
| remove_foreign_key('host_classes', 'hosts') if foreign_key_exists?(:host_classes, :hosts) |
There was a problem hiding this comment.
Any idea whether this error can occur for the other migrations?
There was a problem hiding this comment.
no idea if it can, it didn't in Satellite usecase, but I can add the condition to all of them :)
There was a problem hiding this comment.
Won't hurt I guess :) Any idea why the error occurred in the first place?
There was a problem hiding this comment.
I believe it was because of the FK was created with the table alrady and thus had a default name, not the name given by us.
|
Could you please add a more descriptive commit message :) |
Some foreign keys have been already created with other names or not created at all. This adds a security measure to remove the key whatever the name is if it exists. Fixes theforeman#239
ezr-ondrej
force-pushed
the
fix_purge_task
branch
from
f791111
to
c95fd46
Compare
ezr-ondrej
changed the title
|
Better? :) |
|
LGTM! Thanks @ezr-ondrej |
nadjaheitmann
approved these changes
Dec 16, 2021
|
CP 2.0: 6b5f43a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239