New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid Inventory page components scss overriding other pages #496
Conversation
@ShimShtein @MariaAga can you check if I missed anything? for insights and the host-details-tab pages looks like they are already explicit, to review this PR it's best to view it in unified mode and hide spaces so changes are reduced to ~30: |
10551bd
to
4989fe4
Compare
@adamruzicka that's the one we were talking about, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two more files that need attention:
-
./webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/components/modal.scss
I would rename to something less generic:#inventory_sync_modal
for example -
./webpack/ForemanInventoryUpload/Components/TabHeader/tabHeader.scss
needs wrapping
Also:
Found by searching |
I think those are actually specific enough as they all start with |
4989fe4
to
6c87f6c
Compare
Merged, thanks @LaViro! |
No description provided.