Add proxy parameter to insights forwarded requests #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all requests will inherit the same basic properties.
|
@LaViro, ready for review. |
Ron-Lavi
approved these changes
Jun 6, 2021
There was a problem hiding this comment.
Thanks @ShimShtein ! I tested it with a local HTTP proxy, and seem all calls to the cloud are working as expected 👍🏼
ShimShtein
added a commit
to ShimShtein/foreman_rh_cloud
that referenced
this pull request
Jun 6, 2021
* Refactor RestClient requests to a single factory * Fix tests that require tasks executor * Refactor all RestClient calls to a single method Now all requests will inherit the same basic properties.
ShimShtein
added a commit
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.