Add UUID to insights facets that are missing it #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Jun 22, 2021
Comment on lines
31
to
34
| missing_uuids = existing_facets.select { |host_id, uuid| uuid.empty? }.map(&:first) | ||
|
|
||
| missing_uuids.each do |host_id| | ||
| InsightsFacet.where(host_id: host_id).update_all(uuid: uuids_hash[host_id]) |
There was a problem hiding this comment.
How about something like this this?
Suggested change
| missing_uuids = existing_facets.select { |host_id, uuid| uuid.empty? }.map(&:first) | |
| missing_uuids.each do |host_id| | |
| InsightsFacet.where(host_id: host_id).update_all(uuid: uuids_hash[host_id]) | |
| missing_uuids = existing_facets.select { |host_id, uuid| uuid.empty? }.each do |host_id, uuid| | |
| InsightsFacet.where(host_id: host_id).update_all(uuid: uuid) |
|
@adamruzicka Done! |
adamruzicka
approved these changes
Jun 24, 2021
ShimShtein
added a commit
to ShimShtein/foreman_rh_cloud
that referenced
this pull request
Jun 28, 2021
* Add UUID to insights facets that are missing it * Review fixes
Ron-Lavi
pushed a commit
that referenced
this pull request
Jun 29, 2021
* Add UUID to insights facets that are missing it * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.