Add support for LEAPP data downloads #750
Conversation
|
Thinking a bit about this from a dependency stand point, I tend to expect either: a) this to live in foreman_leapp with a dependency on foreman_rh_cloud It won't be obvious in the current form that there is some leapp related functionality over here in foreman_rh_cloud when trying to debug this or understand the workflow. |
There was a problem hiding this comment.
a) this to live in foreman_leapp with a dependency on foreman_rh_cloud
foreman_leapp lives in plugins, foreman_rh_cloud lives in and depends on katello. You can't have that dependency. Or it needs to be a soft dependency where foreman_leapp detects the presence of foreman_rh_cloud at runtime and enables functionality.
c) foreman_leapp to have a dependency on foreman_rh_cloud
For the same reason, this will break repoclosure.
| @@ -99,6 +105,10 @@ def connection_test_request? | |||
| ->(request_path) { request_path =~ /redhat_access\/r\/insights\/?$/ } | |||
| end | |||
|
|
|||
| def pes_request? | |||
| ->(request_path) { request_path =~ /api\/pes\// } | |||
There was a problem hiding this comment.
I see it was already there before, but have you considered the %r{} notation?
| ->(request_path) { request_path =~ /api\/pes\// } | |
| ->(request_path) { request_path =~ %r{api/pes/} } |
Also note you only perform partial matching, so /something/elseapi/pes/ will also match.
There was a problem hiding this comment.
It comes with the routes filter, so something/else/api/pes wouldn't get here anyway.
|
I don't think People can use Leapp w/o |
|
Converting this to draft, as the team asked us to wait with this feature |
|
Closing, since it is not needed for too long |
LEAPP upgrade tool needs to download files from the cloud, so they need support for forwarding their requests through the server similar to insights-client.