Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #124 #125

Merged
merged 1 commit into from May 12, 2022
Merged

Fixes #124 #125

merged 1 commit into from May 12, 2022

Conversation

jpasqualetto
Copy link
Contributor

Fixes issue #124 using a base64 hash to carry the password to the shell script, instead of using the raw string.

@ares
Copy link
Member

ares commented Aug 21, 2020

That's a nice patch, can we be sure base64 command is always present?

@jpasqualetto
Copy link
Contributor Author

Yes, base64 command is provided by the package coreutils which is always present.

@chris1984 chris1984 merged commit 7f05b96 into theforeman:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants