Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virt-who inline doc #142

Closed
wants to merge 4 commits into from
Closed

Conversation

pipopopo
Copy link

@pipopopo pipopopo commented Feb 1, 2022

Update inline doc as requested in https://bugzilla.redhat.com/show_bug.cgi?id=1884148

@pipopopo
Copy link
Author

pipopopo commented Feb 1, 2022

# erb -x -T '-' _connection_form.erb | ruby -c
Syntax OK

@ares
Copy link
Member

ares commented Feb 1, 2022

Also for the reference, this should reflect the changes done in virt-who itself - candlepin/virt-who#168

@jturel
Copy link
Contributor

jturel commented Feb 1, 2022

Thanks @pipopopo !

Can you squash the commits and rename it to "Fixes #34370 - update filter_host_parents description". I opened https://projects.theforeman.org/issues/34370 on your behalf

Kenny Tordeurs added 2 commits February 1, 2022 19:37
@pipopopo
Copy link
Author

pipopopo commented Feb 1, 2022

I messed up my commits here so I just did a clean PR in #143 and will close this one out.

@pipopopo pipopopo closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants