Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35062 - avoid data contamination in field validation #144

Merged
merged 1 commit into from Jun 16, 2022

Conversation

lfu
Copy link
Contributor

@lfu lfu commented Jun 15, 2022

Changed the way to set up the invalid fields when a hypervisor_type is selected.

To test
1 Create a virt-who config for a non-Nutanix type, eg. Container-native virtualization
2 Create a Nutanix virt-who config
This would fail without fix with error Prism flavor Invalid option for hypervisor [ahv].
Then apply the fix and repeat the steps. All configs should be created without issues.

@chris1984 chris1984 self-assigned this Jun 15, 2022
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, Works well I tried multiple configs and did not hit the error, where i did before applying the patch. Nice work @lfu

@chris1984 chris1984 merged commit d58e4e0 into theforeman:master Jun 16, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants