Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36048 - update_attributes no longer works in Rails 6.1 #156

Merged
merged 1 commit into from Feb 8, 2023
Merged

Fixes #36048 - update_attributes no longer works in Rails 6.1 #156

merged 1 commit into from Feb 8, 2023

Conversation

lfu
Copy link
Contributor

@lfu lfu commented Feb 7, 2023

In Rails 6.1, the update_attributes method no longer works.

To Test
1 Edit virt who config from UI
2 hammer virt-who-config update --interval 240 --id 1

chris1984
chris1984 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, works great thanks @lfu

[root@centos8-stream-katello-nightly ~]# hammer virt-who-config update --interval 240 --id 1
Virt Who configuration [Test] updated

@chris1984 chris1984 self-assigned this Feb 8, 2023
@chris1984 chris1984 added the bug label Feb 8, 2023
@chris1984 chris1984 merged commit a63db81 into theforeman:master Feb 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees

@chris1984 chris1984

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfu @chris1984