Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes #5209 - negative timeout config value causes errors #113

Merged
merged 1 commit into from May 6, 2014

Conversation

tstrachota
Copy link
Member

No description provided.

@@ -18,7 +18,8 @@ def self.resource_config
config[:api_version] = 2
config[:aggressive_cache_checking] = HammerCLI::Settings.get(:foreman, :refresh_cache) || true
config[:headers] = { "Accept-Language" => HammerCLI::I18n.locale }
config[:timeout] = HammerCLI::Settings.get(:foreman, :request_timeout)
config[:timeout] = HammerCLI::Settings.get(:foreman, :request_timeout) || 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the default value set to '0'. I'd go with nil which should default to what restclient uses as default.

@mbacovsky
Copy link
Member

Thanks for the docs, it is appreciated addition. 👍

tstrachota pushed a commit that referenced this pull request May 6, 2014
FIxes #5209 - negative timeout config value causes errors
@tstrachota tstrachota merged commit 8b0c229 into theforeman:master May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants