Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #22253 - Allow mixing option sources and validations #402

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@tstrachota
Copy link
Member

tstrachota commented Dec 14, 2018

This patch makes hammer-cli-katello compatible with changes in:
theforeman/hammer-cli#242

Please see the discussion in the PR into hammer core for more details about the functionality that is going to be merged there.

@mbacovsky

This comment has been minimized.

Copy link
Member

mbacovsky commented Dec 17, 2018

@tstrachota looks good, tests are green locally and runs flawlessly.
It could be useful to add at least a link to option processors docs in core and full processors stack structure to https://github.com/theforeman/hammer-cli-foreman/blob/master/doc/name_id_resolution.md. What do you think?

Tomas Strachota

@tstrachota tstrachota force-pushed the tstrachota:validator_options branch from 35b3e5b to 206e5b8 Dec 17, 2018

@tstrachota

This comment has been minimized.

Copy link
Member Author

tstrachota commented Dec 17, 2018

@mbacovsky updated

@mbacovsky
Copy link
Member

mbacovsky left a comment

Thank you @tstrachota for updating the docs!

@mbacovsky

This comment has been minimized.

Copy link
Member

mbacovsky commented Dec 17, 2018

👍 I'll merge once @akofink confirms hammer-cli-katello is in a good shape with this change and once the tests are green with core part merged

@tstrachota

This comment has been minimized.

Copy link
Member Author

tstrachota commented Dec 17, 2018

@mbacovsky would you mind pinging him? Since his last comment was "I want to re-review after the dependent changes are finalized." I'm afraid we could end up in a deadlock :)

@mbacovsky

This comment has been minimized.

Copy link
Member

mbacovsky commented Dec 17, 2018

[test hammer]

@mbacovsky

This comment has been minimized.

Copy link
Member

mbacovsky commented Dec 17, 2018

Tests are green, merging. Thanks @tstrachota, @akofink! 🍻

@mbacovsky mbacovsky merged commit 12fc9d6 into theforeman:master Dec 17, 2018

1 check passed

hammer Build finished. 5070 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.