Fixes #34177 - Domain update doesn't reset DNS implicitly #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2021
|
[test hammer] |
1 similar comment
|
[test hammer] |
ofedoren
force-pushed
the
bug-34177-fix-domain-update
branch
from
e8faebb
to
ec5abc7
Compare
|
@ofedoren Thanks Oleh LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
hammer domain update --id 1will send alsodns_id => nilas a parameter. The reseting of the DNS should be explicit by the users.UPD: for all tests to pass theforeman/hammer-cli#357 is required.