Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7451 - Review whitespace in extracted strings #258

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@ofedoren
Copy link
Member

commented Nov 7, 2017

No description provided.

@mbacovsky

This comment has been minimized.

Copy link
Member

commented Nov 8, 2017

[test]

@ofedoren ofedoren force-pushed the ofedoren:bug-7451-whitespace branch from e7fcdfb to 5ae7b80 Nov 14, 2017

@tstrachota

This comment has been minimized.

Copy link
Member

commented Dec 6, 2017

[test]

@tstrachota

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

👍 good job @ofedoren !
Would you mind doing the same also for hammer-cli-foreman ?

@tstrachota tstrachota merged commit d45d316 into theforeman:master Dec 7, 2017

1 check passed

default Job result: SUCCESS
Details
@mbacovsky

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

@ofedoren, we've been too quick merging this and had to revert. I found two issues there:

Could you please reopen this PR and create a new one for the hammer-cli-foreman?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.