New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release view templates #176
Conversation
- '1' | ||
|
||
- view: | ||
name: 'Foreman Nightly' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line and each below need to be indented
- project: | ||
name: 'foreman-releases' | ||
views: | ||
- '{name}-template-{major}.{minor}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to match the name:
defined on https://github.com/theforeman/jenkins-jobs/pull/176/files#diff-b6bd4b212bdd5eae7e1f14909bf3b48d97db0a2b5d14afd613c56b60ddc54528R2 in order for it to link them up properly
This adds templated views for releases which makes it easier to have the correct version tabs for a quick overview.
At least the tests are green now. When we deploy this, I don't know whether it'll remove all non-managed views or if we don't purge those. |
We run
|
Doesn't look like it's starting to manage views:
So it probably doesn't proceed with views until that's fixed. |
Ok, so I had to:
Now we have views: The former does have a list of unstable jobs, which can be quite useful. And the description may not be that useful and only takes up space. |
Is this something that can be denoted in JJB to include? Now that this is working - is our follow up to put the rest of the views into code? |
I haven't checked yet
Yes, I do think that would be a good thing. It would remove yet another piece of manually managed Jenkins. |
This adds templated views for releases which makes it easier to have the correct version tabs for a quick overview.
Currently untested. I've followed https://docs.openstack.org/infra/jenkins-job-builder/definition.html#views but I don't know if this will start to purge unmanaged views.
Fixes #169