Add links to the referenced/fixed issues #59
Conversation
|
@akofink, +1 for me. It would save me the time of formulating the link for every PR.... Thanks! |
app.rb
Outdated
| @@ -78,6 +78,13 @@ | |||
| end | |||
|
|
|||
| if ENV['GITHUB_OAUTH_TOKEN'] | |||
| if pull_request.new? && pull_request.issue_numbers.any? | |||
There was a problem hiding this comment.
Please add this to the per-repo configuration.
| Katello/hammer-cli-sam: | ||
| redmine: katello | ||
| Katello/katello: | ||
| pr_scanner: true | ||
| redmine: katello | ||
| redmine_required: true | ||
| link_to_redmine: true |
There was a problem hiding this comment.
You can add this to katello-installer and katello-packaging
|
This should be good to go. |
|
👍 I'd love to have this in foreman core as well tbh. |
|
Updated to include foreman core. |
|
Any updates on this? |
|
Rebased. Waiting on reviewers. |
github/pull_request.rb
Outdated
| message = issue_numbers.inject("\nIssues:") do |msg, issue_number| | ||
| msg + " [##{issue_number}](http://projects.theforeman.org/issues/#{issue_number})" | ||
| end | ||
| append_pull_request_body(message) |
There was a problem hiding this comment.
So this does not add a fresh comment? How does the output on a PR come out to look like if this is updating the issue? Are we altering the users first comment ?
There was a problem hiding this comment.
I'm not sure we should be editing other users comments and posts directly. While it does create an additional notification, this would be altering a users comment and making it seem as if the user posted that? If I do a merge instead of squash or rebase does this edit get put into the commit message for the merge?
There was a problem hiding this comment.
This absolutely does not modify the commit message, only the pull request description on a new PR with issue numbers in the commit message.
|
Updated to add a comment instead of appending the description @ehelms |
as a comment on a new PR
as a comment on a new PR
Open to discussion!