Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: theforeman/puppet-dns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.1.0
Choose a base ref
...
head repository: theforeman/puppet-dns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.2.0
Choose a head ref
  • 4 commits
  • 10 files changed
  • 2 contributors

Commits on Jul 16, 2019

  1. Allow setting service restart command

    By default the service resource that manages the BIND service will
    restart the service when notified by configuration changes. This can be
    disruptive.
    
    This change allows the user to set a custom restart command via
    `dns::service_restart_command` for the service resource, such as
    `/usr/sbin/service bind9 reload` or `/bin/systemctl reload bind9.service`
    or even `/usr/sbin/rndc reload`, to avoid restarting the whole named
    process. By default no restart command is set.
    antaflos authored and ekohl committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    6bb26ca View commit details
    Browse the repository at this point in the history
  2. Validate named.conf and zones.conf using named-checkconf

    Make use of the `validate_cmd` parameter in concat to run
    named-checkconf on the target file. This way the validity of to-be-updated
    configuration files named.conf or zones.conf is checked before actually
    writing the new configuration and restarting the named service. This
    prevents named from loading invalid configuration settings that would
    result in named failing to start.
    
    The file named.conf.options itself cannot be checked with
    named-checkconf because its content is only valid inside the
    "options { };" directive.
    antaflos authored and ekohl committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    526d4db View commit details
    Browse the repository at this point in the history
  3. Don't set forbidden zone options for zone type 'forward'

    When zonetype => forward is set for a dns::zone resource then ignore any
    forbidden options that might be set as parameters when rendering the
    named.zone.erb template. Such forbidden options are "file", "masters",
    "allow-transfer", "allow-query", "notify" and "also_notify".
    
    This prevents the module from generating an invalid named configuration
    (in zones.conf) that would result in named failing to (re)start.
    
    Fixes GH-141
    antaflos authored and ekohl committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    9a0339b View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Release 6.2.0

    ekohl authored and mmoll committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e47bcad View commit details
    Browse the repository at this point in the history
Loading