Don't set forbidden zone options for zone type 'forward'

[antaflos]

When zonetype => forward is set for a dns::zone resource then ignore any
forbidden options that might be set as parameters when rendering the
named.zone.erb template. Such forbidden options are "file", "masters",
"allow-transfer", "allow-query", "notify" and "also_notify".

This prevents the module from generating an invalid named configuration
(in zones.conf) that would result in named failing to (re)start.

Fixes GH-141

[theforeman-bot]

@antaflos, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

• check #141: add support to extlookup kind of queries through foreman is the correct one
• move ticket #141 from Foreman to the Installer project
• or file a new ticket in the Installer project

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).

---

This message was auto-generated by Foreman's prprocessor

[ekohl]

Should we do these checks in puppet code and hard error when it's passed in? I like hard failures in catalog compilation so you're aware that you're passing in an invalid configuration.

[antaflos]

In this case I thought it may be easier and more efficient to make the template aware of the zone type and let it "do the right thing" on its own, without failing the catalog compilation.

The use case I thought of was this: when most zones are slave zones we can set defaults for the dns::zone type in Hiera or in a profile, like zonetype => slave and manage_file_name => true. Then we can override the zonetype default for specific zones by setting zonetype => forward and we don't have to set or change manage_file_name; it can remain at its set default value since it is just ignored for the forward zone type.

But if you want I can also change the behaviour like you suggested and fail with a hard error if this is the preferable way to go for this module.

[antaflos]

Gently bumping this as well :)

[ekohl]

Thanks!