Allow setting service restart command #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaflos
force-pushed
the
service_restart_command
branch
from
0de86b5
to
cf3506b
Compare
|
I have rebased the branch on the current master and force-pushed. |
ekohl
approved these changes
Jun 4, 2019
By default the service resource that manages the BIND service will restart the service when notified by configuration changes. This can be disruptive. This change allows the user to set a custom restart command via `dns::service_restart_command` for the service resource, such as `/usr/sbin/service bind9 reload` or `/bin/systemctl reload bind9.service` or even `/usr/sbin/rndc reload`, to avoid restarting the whole named process. By default no restart command is set.
antaflos
force-pushed
the
service_restart_command
branch
from
cf3506b
to
b30a6eb
Compare
ekohl
approved these changes
Jul 16, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the service resource that manages the BIND service will
restart the service when notified by configuration changes. This can be
disruptive.
This change allows the user to set a custom restart command via
dns::service_restart_commandfor the service resource, such as/usr/sbin/service bind9 reloador/bin/systemctl reload bind9.serviceor even
/usr/sbin/rndc reload, to avoid restarting the whole namedprocess. By default no restart command is set.