Validate named.conf and zones.conf using named-checkconf #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs more work to appease the acceptance tests. |
antaflos
force-pushed
the
validate_named_conf_files
branch
2 times, most recently
from
2f7c522
to
c88f5ec
Compare
antaflos
force-pushed
the
validate_named_conf_files
branch
from
c88f5ec
to
93b15ae
Compare
|
I have rebased the branch on the current master and force-pushed. |
ekohl
requested changes
Jun 4, 2019
Make use of the `validate_cmd` parameter in concat to run
named-checkconf on the target file. This way the validity of to-be-updated
configuration files named.conf or zones.conf is checked before actually
writing the new configuration and restarting the named service. This
prevents named from loading invalid configuration settings that would
result in named failing to start.
The file named.conf.options itself cannot be checked with
named-checkconf because its content is only valid inside the
"options { };" directive.
antaflos
force-pushed
the
validate_named_conf_files
branch
from
93b15ae
to
d32652b
Compare
|
Bumping gently :) |
ekohl
approved these changes
Jul 16, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the
validate_cmdparameter in concat to runnamed-checkconf on the target file. This way the validity of to-be-updated
configuration files named.conf or zones.conf is checked before actually
writing the new configuration and restarting the named service. This
prevents named from loading invalid configuration settings that would
result in named failing to start.
The file named.conf.options itself cannot be checked with
named-checkconf because its content is only valid inside the
"options { };" directive.