Refactor soaip in dns::zone #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
optional-soaip
branch
2 times, most recently
from
62401a8
to
5b33f1a
Compare
|
So I can't reproduce the failure on a vagrant_libvirt VM. Also docker running on CentOS7. However, I can on docker-ce 19.03.5. |
|
#152 to work around this. |
|
please rebase :) |
This was removed from puppetlabs-concat a long time ago.
This makes the $soaip parameter optional since in many cases it doesn't makes sense. It was also breaking hard on IPv6-only systems. For those setups the $soaipv6 parameter is also added. The types are also tightened to the correct address family.
ekohl
force-pushed
the
optional-soaip
branch
from
5b33f1a
to
5dffa70
Compare
|
💚 |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the $soaip parameter optional since in many cases it doesn't makes sense. It was also breaking hard on IPv6-only systems. For those setups the $soaipv6 parameter is also added. The types are also tightened to the correct address family.