Add the ability to define logging #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jul 6, 2020
|
Is there anything else needed here? |
ekohl
reviewed
Jul 20, 2020
ekohl
reviewed
Jul 20, 2020
ekohl
reviewed
Jul 30, 2020
There was a problem hiding this comment.
My main concern is adding additional files, especially if they're unused by default.
One way to reduce that is to add a class dns::logging that adds the logging include to the main config and creates $logdir. Then you can require dns::logging in dns::logging::category and dns::logging::channel.
Other than that it looks good. Some more small coding style suggestions inline.
|
@ekohl I refactored this to append to |
* Update README including fixing bare links * Add spec and acceptance tests as needed
|
@ekohl I think this should be all set now. Let me know if there is anything else you would want updated before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no way in the current settings to configure a log directory or an advanced logging configuration using channels and categories. This change adds the necessary configuration options and template changes to create a full-featured logging configuration. README and spec changes have been completed to document and test the change.