Fix custom key ordering #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 3, 2020
coreone
force-pushed
the
keyorder
branch
2 times, most recently
from
1c5add7
to
a6d7405
Compare
ekohl
reviewed
Sep 3, 2020
ekohl
reviewed
Sep 3, 2020
|
@ekohl is there anything else needed here? |
ekohl
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a custom key, the configuration validation would fail on the first run as the configuration would be updated and the validation would run before the key was created. The error would go away on the second run as the file would then exist before the configuration was updated (from the previous run). The updated ordering in
dns::keymakes this now work on the first run without an error.As a note, the
groupcreation needed to be moved out ofdns::configto prevent a dependency cycle.