Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CentOS 9, Debian 11 and Ubuntu 20.04 #201

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 27, 2022

No description provided.

@wbclark
Copy link
Contributor

wbclark commented Jan 31, 2022

not a new issue with this PR but it looks like centos8 doesn't get included in the test matrix due to a necessary workaround implemented in puppet_metadata... is it possible to test with centos8-stream without marking it as a supported OS in metadata?

@ekohl
Copy link
Member Author

ekohl commented Jan 31, 2022

not a new issue with this PR but it looks like centos8 doesn't get included in the test matrix due to a necessary workaround implemented in puppet_metadata... is it possible to test with centos8-stream without marking it as a supported OS in metadata?

It should be supported since it's already in metadata. The reason it's now skipped is that in the past we had problems with the PIDFile= part in systemd which broke under Docker. I've opened #202 to see if that's still really a problem.

@ekohl ekohl merged commit d454f6e into theforeman:master Jan 31, 2022
@ekohl ekohl deleted the add-os-support branch January 31, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants