Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage zone records #212

Merged
merged 5 commits into from May 5, 2022
Merged

Manage zone records #212

merged 5 commits into from May 5, 2022

Conversation

BDelacour
Copy link
Contributor

@BDelacour BDelacour commented May 3, 2022

See #196

@ekohl Is it OK for you to manage zone without validation or would you prefer a more specific type (which would lead to a configuration more difficult to maintain) ?

Example :

  • I created something like this (in Hiera)
dns::zones:
  example.com:
    replace_file: true
    serial: 2
    records:
      - host1 IN A 192.168.0.1
      - host2 IN A 192.168.0.2
  • Or you want something like this (don't mind the naming, just for the format)
dns::zones:
  example.com:
    replace_file: true
    serial: 2
    records:
      - name: host1
         xx: IN
         type: A
         dst: 192.168.0.1
...

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you explicitly pinged me, I gave it a quick look but I'm on leave so officially not working. @evgeni / @ehelms would you mind taking care of this? I just approved CI so the tests can run and some minor inline comments on small details, but the general idea looks good to me.

manifests/zone.pp Outdated Show resolved Hide resolved
manifests/zone.pp Show resolved Hide resolved
@ekohl ekohl linked an issue May 5, 2022 that may be closed by this pull request
Benjamin Delacour and others added 2 commits May 5, 2022 11:53
@evgeni evgeni merged commit 301c6d5 into theforeman:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage zone records
4 participants