stopped zone file from being created if zone type is forward #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluates if zone file is managed and zone file is not a forward, if the zone file is a forward type there is no value in creating the zone file as it will forward all requests.
There is a slim risk that someone may want a forward zone file that is forward first rather than forward only, upon research this usecase is obsolete in bind deployments and was a requirement due to some of the legacy capabilities in earlier versions of bind.
If this risk is not an acceptable one to merge into the module, I can expand the evaluation to be zonetype and for include if the forward parameter is 'first' rather than 'only' which is the default for a foward zone.
I believe this is an acceptable use-case to ignore