Remove legacy fact usage #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
legacy-facts
branch
2 times, most recently
from
be42611
to
d3556b3
Compare
ekohl
requested changes
Dec 27, 2022
| @@ -63,7 +63,7 @@ | |||
| define dns::zone ( | |||
| Array[String] $target_views = [], | |||
| String $zonetype = 'master', | |||
| String $soa = $fqdn, | |||
| String $soa = $facts['networking']['fqdn'], | |||
There was a problem hiding this comment.
Odd that the lint plugin to find legacy facts didn't find this.
We can now run puppet without legacy facts: ``` puppet config set include_legacy_facts false ``` When doing so, the module fail to get the default value for $dns::zone::soa. Fix it by using the networking.fqdn fact. While here, adjust a few more legacy facts.
smortex
force-pushed
the
legacy-facts
branch
from
d3556b3
to
a4bd115
Compare
ekohl
approved these changes
Dec 27, 2022
|
I'll consider this as a bugfix to 6426a39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now run puppet without legacy facts:
When doing so, the module fail to get the default value for
$dns::zone::soa. Fix it by using thenetworking.fqdnfact.While here, adjust a few more legacy facts.