Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sysconfig_file for Debian/Ubuntu to '/etc/default/named' #238

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 28, 2023

It is was changed quite a while back.

Fixes #234

@frittentheke
Copy link

@evgeni did you get a chance to look at this one?

@evgeni
Copy link
Member

evgeni commented Sep 15, 2023

If only GitHub would notify people about a requested review… Looking.

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one could argue we could just drop support for those old releases, but until we do the diff is correct

@ekohl
Copy link
Member Author

ekohl commented Sep 15, 2023

one could argue we could just drop support for those old releases, but until we do the diff is correct

I didn't want to do a breaking change just now.

@ekohl ekohl merged commit cf568c8 into theforeman:master Sep 15, 2023
12 checks passed
@ekohl ekohl deleted the sysconfig-file branch September 15, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sysconfig_file for Debian and Ubuntu is wrong and has long changed to /etc/default/named
4 participants