Add support for empty forwarders in master zone #244
Conversation
manifests/zone.pp
Outdated
| @@ -51,6 +51,8 @@ | |||
| # @param zonefilepath | |||
| # @param filename | |||
| # @param forward | |||
| # @param master_empty_forwarders_enable | |||
| # Enable empty forwarders option in master zone | |||
There was a problem hiding this comment.
I think this is a bit brief. It doesn't explain that forwarders must be empty and zonetype set to master.
There was a problem hiding this comment.
Hello @ekohl,
Thank you for looking into this and for your feedback.
Description for master_empty_forwarders_enable parameter was updated as you suggested.
| <% if @forwarders.empty? && @master_empty_forwarders_enable -%> | ||
| forwarders {}; |
There was a problem hiding this comment.
Is there a reason to enforce that forwarders is empty? Isn't there a case to be made for master_forwarders_enable?
https://serverfault.com/questions/713256/purpose-of-a-forwarder-option-in-a-master-zone suggests there is also a case to be made to actually include forwarders, instead of discarding the forwarders values provided.
There was a problem hiding this comment.
Possibility to enforce empty forwarders is for disabling global forwarding when server is authoritative for domain and subdomain is delegated.
Related link:
https://kb.isc.org/docs/aa-00538
Possibility to include forwarders in master zone was introduced now as well.
This gives possibility to enable forwarding in master zone. Add support for empty forwarders in master zone Allows to disable forwarding in master zone to cover scenario when server is authoritative for domain, subdomain is delegated and global forwarding is set.
mbarecki
force-pushed
the
master-zone-empty-forwarders
branch
from
3497cdd
to
97eaeae
Compare
This gives possibility to disable forwarding for delegated zone when server is authoritative for domain and global forwarding is set.