refs #7234 - install foreman-release-scl on EL clones #236
Conversation
Foreman-specific SCL release package will replace per-distro SCL configuration as it's more complex and more up to date. configure_*_repo logic moved into parameter defaults which also allows users to override the logic (e.g. on RHEL self-support, it can now be enabled).
| @@ -29,8 +29,9 @@ | |||
| # Choose whether you want to enable locations and organizations. | |||
| $locations_enabled = false | |||
| $organizations_enabled = false | |||
| $configure_epel_repo = true | |||
| $configure_scl_repo = true | |||
| $configure_epel_repo = ($::osfamily == 'RedHat' and $::operatingsystem != 'Fedora') | |||
There was a problem hiding this comment.
I'm glad, I was unsure which way to do it. I think this is better, as then users can force an override either way.
There was a problem hiding this comment.
Exactly. Ideally there is no distro specific logic inside classes other than params.pp.
|
👍 in general. Just wondering if this will also work for all supported versions of foreman. I think we agreed on the latest released version and develop, so that would be 1.6 and nightlies. |
|
I intend to push the new package into 1.6, because it's needed for EL7 rebuild (CentOS) support, as we released 1.6 without officially supporting it. EDIT: unsure if it'll make 1.6.1, probably .2 at this rate. |
|
LGTM |
|
Package is now available in nightly repos, I'll pull it into 1.6.1 too as it's a harmless addition. |
|
Package is now available in 1.6 repos. |
|
I like it how it takes the author of the commit, not the committer. Anyway, merged now. |
Foreman-specific SCL release package will replace per-distro SCL configuration as it's more complex and more up to date. configure_*_repo logic moved into parameter defaults which also allows users to override the logic (e.g. on RHEL self-support, it can now be enabled). Closes theforemanGH-236.
Depends on theforeman/foreman-packaging#364
Foreman-specific SCL release package will replace per-distro SCL configuration
as it's more complex and more up to date.
configure_*_repo logic moved into parameter defaults which also allows users to
override the logic (e.g. on RHEL self-support, it can now be enabled).