fixes #8489 - set KeepAlive On in foreman vhost #405
Conversation
|
LGTM but I don't have enough confidence to merge Puppet stuff. Also, I think we should parametrize MaxKeepAliveRequests and KeepAliveTimeout options. |
|
@lzap like that? |
|
That looks good, you can also parametrize keep-alive itself. |
|
@lzap done 馃巵 |
| @@ -246,6 +257,9 @@ | |||
| $server_ssl_certs_dir = $::foreman::params::server_ssl_certs_dir, | |||
| $server_ssl_key = $::foreman::params::server_ssl_key, | |||
| $server_ssl_crl = $::foreman::params::server_ssl_crl, | |||
| $keepalive = $::foreman::params::keepalive, | |||
There was a problem hiding this comment.
Call validate_*() on these parameters?
There was a problem hiding this comment.
I do in manifests/config/passenger.pp
|
馃憤 when the validation functions are used. |
| # (Number of requests allowed on a persistent connection) | ||
| # type:integer | ||
| # | ||
| # $keepalivetimeout:: KeepAliveTimeout setting of Apache |
There was a problem hiding this comment.
Should these parameters contain underscores separating the words? Other parameters do, e.g. passenger_start_timeout
|
馃憤 when tests pass. I tested the earlier version (prior to the parameter rename) successfully. |
|
Merged, thanks @mmoll. |
As it seems to be still a longer time to puppetlabs-apache 2.0, handle this in the vhost.
@lzap for your testing pleasure... 馃悓