Fixes #31215 - Generate DSL docs #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 13, 2020
ofedoren
force-pushed
the
feat-add-apipie-dsl
branch
from
0a6e2ee
to
467861d
Compare
|
@ekohl, what's the status here?.. |
wbclark
reviewed
Oct 29, 2020
There was a problem hiding this comment.
This change worked fine for me both in testing the individual puppet module and also in foreman-installer (tested via Forklift with the module_prs feature)
@ofedoren before we merge this could you please create a Redmine Issue and update the commit message and PR title to reference the Issue # ? For example, "Fixes #XXXXX - Generate DSL docs"
ofedoren
force-pushed
the
feat-add-apipie-dsl
branch
from
467861d
to
63bd436
Compare
|
Thanks, @wbclark! Done. |
wbclark
approved these changes
Oct 29, 2020
|
Thanks @ofedoren ! It is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ekohl, please, let me know if I should link it to the Redmine or add/change something else.
My intention here is to add generating of DSL docs similarly to API docs after Foreman or a plugin is installed.