New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-provider DNS configuration files #182

Closed
domcleal opened this Issue Jul 13, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@domcleal
Copy link
Contributor

domcleal commented Jul 13, 2015

Smart Proxy 1.10 will ship separate configuration files for DNS providers, instead of one large dns.yml. The templates in this module will need splitting up.

See https://github.com/theforeman/smart-proxy/tree/d905c67c/config/settings.d for example.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 13, 2015

I can't quite figure out we'd do the compatibility. It looks every plugin has its own config "namespace" so we need to figure out which version we're going to deploy for. The ugly solution would be a split_dns_config_files parameter (like we did in puppet-foreman with {report,node}_v{1,2}.rb), but that'd work. It could default to true.

@domcleal

This comment has been minimized.

Copy link
Contributor

domcleal commented Jul 13, 2015

I was thinking that we probably wouldn't bother with compatibility on this change.. but I don't know how many more incompatible changes are coming, and in which releases - I doubt we'd get all of those modules split in time for 1.10, so it might happen again soon.

But yes, I think we'd have to add some new parameters to retain compatibility - either feature based, like whether config files are split or not, or a single version parameter.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Sep 14, 2015

Another thing we must handle is dns_provider changed to use_provider.

ekohl added a commit to ekohl/puppet-foreman_proxy that referenced this issue Sep 14, 2015

ekohl added a commit to ekohl/puppet-foreman_proxy that referenced this issue Sep 14, 2015

ekohl added a commit to ekohl/puppet-foreman_proxy that referenced this issue Sep 19, 2015

@ekohl ekohl closed this in d10584a Sep 19, 2015

ehelms pushed a commit to ehelms/puppet-foreman_proxy that referenced this issue Aug 25, 2017

Merge pull request theforeman#182 from lzap/master
Added discovery 4.0 plugin branch config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment