Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the dns_powerdns plugin #189

Closed
wants to merge 1 commit into from
Closed

Conversation

@ekohl
Copy link
Member

@ekohl ekohl commented Sep 2, 2015

This is untested and just something to refer to for now.

@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from d97a38a to b00a5fa Sep 2, 2015
ekohl added a commit to ekohl/foreman-installer that referenced this pull request Sep 2, 2015
@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from b00a5fa to e40497f Sep 3, 2015
@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 3, 2015

I'm considering adding flags to manage mysql or at least the grant. Thoughts?

@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 3, 2015

I split it into a separate commit for easier review if it's desired.

@domcleal
Copy link
Contributor

@domcleal domcleal commented Sep 4, 2015

Managing the DB sounds like a useful feature, at least until the plugin has API support.

@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from 5c78f54 to 495e8c9 Sep 4, 2015
@mmoll
Copy link
Contributor

@mmoll mmoll commented Sep 5, 2015

This is looking good and the mysql module is already in the installer module set anyway.

@domcleal
Copy link
Contributor

@domcleal domcleal commented Sep 7, 2015

Perhaps add a little note to the README to indicate the soft dependency from this class?

@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from 495e8c9 to d75c681 Sep 8, 2015
@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 8, 2015

Something like this?

@domcleal
Copy link
Contributor

@domcleal domcleal commented Sep 8, 2015

Yep. Looks fine to me. Do you want to test compilation with the DB management?

@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 8, 2015

Sounds like a good idea. I also plan to test this module on a real system and then remove [WIP] somewhere this week.

README.md Outdated
$dns_managed => false
$dns_provider => 'dns_powerdns'

Then you also need to include `foreman::plugin::dns::powerdns`.

This comment has been minimized.

@ekohl

ekohl Sep 12, 2015
Author Member

s/foreman/foreman_proxy/

@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 19, 2015

Will rebase when #190 is merged because it doesn't work without it.

@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from d75c681 to 25666ff Sep 19, 2015
@ekohl ekohl changed the title [WIP] Support the dns_powerdns plugin Support the dns_powerdns plugin Sep 19, 2015
@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 19, 2015

Verified it works on Jessie.

@mmoll
Copy link
Contributor

@mmoll mmoll commented Sep 19, 2015

👍

@domcleal
Copy link
Contributor

@domcleal domcleal commented Sep 21, 2015

Looks good to me, but should we also test the class with manage_database => true?

@ekohl
Copy link
Member Author

@ekohl ekohl commented Sep 21, 2015

Will do

ekohl added a commit to ekohl/foreman-installer that referenced this pull request Oct 1, 2015
.sync.yml Outdated
@@ -3,3 +3,4 @@ Rakefile:
param_docs_pattern:
- manifests/init.pp
- manifests/plugin/*.pp
- manifests/plugin/dns/*.pp

This comment has been minimized.

@domcleal

domcleal Oct 8, 2015
Contributor

This'll need a rebase after 39af736, but the fix in that commit will probably suffice for you too.

@ekohl ekohl force-pushed the ekohl:dns_powerdns branch from 25666ff to 7967bea Oct 8, 2015
@ekohl
Copy link
Member Author

@ekohl ekohl commented Oct 8, 2015

Updated

@domcleal
Copy link
Contributor

@domcleal domcleal commented Oct 9, 2015

👍, though #196 should fix the unrelated test failures.

@ekohl ekohl closed this in caf8f91 Oct 9, 2015
@mmoll
Copy link
Contributor

@mmoll mmoll commented Oct 9, 2015

merged, bedankt @ekohl!

ekohl added a commit to ekohl/foreman-installer that referenced this pull request Oct 9, 2015
ekohl added a commit to theforeman/foreman-installer that referenced this pull request Oct 9, 2015
ekohl added a commit to theforeman/foreman-installer that referenced this pull request Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants