Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #24690 - add symlink grub2/boot to ../boot #449

Merged
merged 1 commit into from Aug 23, 2018

Conversation

@stbenjam
Copy link
Member

commented Aug 22, 2018

No description provided.

@lzap

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

Can you make the symlink relative? It does not matter for HTTPBoot environment (http server in proxy) but in TFTP environment it runs in chroot thus the link is invalid. Troubleshooting this was a nightmare until I found why TFTP is giving me "Not found". Just in case someone will drop grub2 config files there and attempt to use this path via TFTP.

@stbenjam stbenjam force-pushed the stbenjam:24690 branch from f32a9ce to 69ff6a2 Aug 22, 2018

@stbenjam

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2018

Oh right, good catch! Updated

@stbenjam stbenjam force-pushed the stbenjam:24690 branch from 69ff6a2 to 0cf0b5d Aug 22, 2018

@lzap

lzap approved these changes Aug 23, 2018

@mmoll mmoll merged commit 284dd79 into theforeman:master Aug 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mmoll

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

merged, thanks @stbenjam!

@ekohl ekohl added the Bug label Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.