Fixes #3850 - Accept an array of reverse DNS zones #90

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
Owner

GregSutcliffe commented Feb 7, 2014

This allows you to use a network like 10.1.0.0/23 and specify something like:

--foreman-proxy-dns-reverse=0.1.10.in-addr.arpa --foreman-proxy-dns-reverse=1.1.10.in-addr.arpa

to the installer, which then correctly generates both zones.

@domcleal domcleal and 1 other commented on an outdated diff Feb 10, 2014

manifests/init.pp
@@ -109,7 +109,8 @@
#
# $dns_zone:: DNS zone name
@domcleal

domcleal Feb 10, 2014

Owner

Shall we do the same here?

Owner

domcleal commented Feb 10, 2014

👍

Owner

GregSutcliffe commented Feb 10, 2014

@domcleal dns_zone is done

Owner

domcleal commented Feb 10, 2014

The tests exploded.

Owner

GregSutcliffe commented Feb 12, 2014

Gah, 2 character test fix - seems to be passing now :)

Owner

GregSutcliffe commented Feb 17, 2014

@domcleal ping?

Owner

domcleal commented Feb 17, 2014

👍

@ekohl ekohl commented on an outdated diff Feb 17, 2014

manifests/init.pp
@@ -109,9 +109,11 @@
#
# $dns_interface:: DNS interface
#
-# $dns_zone:: DNS zone name
+# $dns_zone:: Array of DNS zone names
@ekohl

ekohl Feb 17, 2014

Member

Not sure I like the name being singular while the value is plural.

Owner

GregSutcliffe commented Feb 25, 2014

@ekohl shall I fix that?

Member

ekohl commented Feb 25, 2014

@GregSutcliffe I wonder how much compatibility we want to keep. I'd prefer to have a parameter dns_zones, but not sure if we should keep dns_zone to stay compatible. Same for reverse.

Owner

GregSutcliffe commented Feb 25, 2014

I'm in favour of moving to plural and not worrying too much about backwards compat here. @domcleal ?

Owner

domcleal commented Feb 25, 2014

Compatibility would be a nice bonus, then we won't have to bump the module by a major release.

Owner

GregSutcliffe commented Feb 25, 2014

hmm how would we do it? $dns_zone = inline_template("<%= dns_zones.first %>") ?

Member

ekohl commented Feb 25, 2014

I'd default dns_zone and dns_zones to some values ('' and [] come to mind), error if both are set. You can use the first non-empty value and show a deprecation notice if dns_zone is set.

mmoll and others added some commits Sep 16, 2016

@mmoll @domcleal mmoll msync: don't test Scientific Linux 6.x
(cherry picked from commit f1ef1ea)
c76f02f
@iNecas @domcleal iNecas Handle rex ssh dependencies in packaging
smart_proxy_remote_execution_core was removed in 1.13
and even before, it was already handled in packaging.
No need to repeat ourselves here.

Fixes #287

(cherry picked from commit a00d136)
60d74c2
@domcleal domcleal Prepare 4.0.1 changelog [skip ci] b74b77c
@GregSutcliffe GregSutcliffe WIP: Arch support 60f5e7f
Member

ekohl commented Oct 20, 2016

@GregSutcliffe did you push some completely different content to this branch?

Owner

GregSutcliffe commented Oct 20, 2016

@ekohl Ugh, I'd forgotten this was still open, to be honest. Shall we just close it?

Member

ekohl commented Oct 20, 2016

Let's

ekohl closed this Oct 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment