Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #8710 - install katello-debug by default #33

Merged
merged 1 commit into from Feb 23, 2015

Conversation

lzap
Copy link
Member

@lzap lzap commented Feb 3, 2015

@lzap
Copy link
Member Author

lzap commented Feb 19, 2015

Hello, anyone? @iNecas @jlsherrill Thanks!

@lzap
Copy link
Member Author

lzap commented Feb 19, 2015

Context: I've created foreman-debug and katello-debug subpackages. We want to install them on the Server as well as on the Capsules. Katello-debug has dependency of foreman-debug (it is technically an "extension" to it).

@stbenjam
Copy link
Member

Yea this is fine, but the package has to exist before we merge it, it's not in the nightly repos yet.

I imagine because the Pipeline is red? http://ci.theforeman.org/view/Katello%20Pipeline/

@@ -5,6 +5,10 @@
package{ ['rubygem-smart_proxy_pulp']:
ensure => installed,
}

package{ ['katello-debug']:
ensure => installed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually why is this in the if block for pulp? We should always install katello-debug, or should we?

@iNecas
Copy link
Member

iNecas commented Feb 19, 2015

What @stbenjam sais

@lzap
Copy link
Member Author

lzap commented Feb 20, 2015

Right fixed.

@stbenjam
Copy link
Member

Looks like the packages are there now, so ACK

@stbenjam
Copy link
Member

@lzap You can merge your own PR's, it's how it's done in the Katello GitHub org, but I'll merge this one

stbenjam added a commit that referenced this pull request Feb 23, 2015
Refs #8710 - install katello-debug by default
@stbenjam stbenjam merged commit 0aa227f into theforeman:master Feb 23, 2015
@lzap lzap deleted the katello-debug-install branch February 24, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants