Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #13189 - allows authentication with username and certificate #112

Merged
merged 1 commit into from Jan 31, 2016

Conversation

cfouant
Copy link
Contributor

@cfouant cfouant commented Jan 22, 2016

No description provided.

@ehelms
Copy link
Member

ehelms commented Jan 22, 2016

MInd changing the commit message a bit to not include capsules since they are not part of Pulp itself? That way it better captures what this enables with respect to Pulp access.

@cfouant cfouant changed the title fixes #13189 - configures capsule to authenticate with username and certificate fixes #13189 - allows authentication with username and certificate Jan 26, 2016
@cfouant cfouant force-pushed the certauth branch 3 times, most recently from 0659ac7 to 211b449 Compare January 26, 2016 16:50
@cfouant
Copy link
Contributor Author

cfouant commented Jan 26, 2016

@ehelms - updated commit message, thanks

@@ -0,0 +1,5 @@
#
# Apache configuration file for Pulp's Puppet support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect documentation, I think you'd be OK reducing this to a one line comment above the directive.

@ehelms
Copy link
Member

ehelms commented Jan 31, 2016

ACK - thanks @cfouant !

ehelms added a commit that referenced this pull request Jan 31, 2016
fixes #13189 - allows authentication with username and certificate
@ehelms ehelms merged commit f086577 into theforeman:master Jan 31, 2016
@cfouant cfouant deleted the certauth branch January 31, 2016 19:58
cegeka-jenkins pushed a commit to cegeka/puppet-pulp that referenced this pull request Oct 23, 2017
fixes #13189 - allows authentication with username and certificate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants