Fixes #23233 - updated yum_max_speed example to reflect to_bytes parsing #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If pulp understands these strings, why do we even convert them to bytes in the first place? I'd be happy with removing |
ekohl
requested changes
Apr 12, 2018
templates/yum_importer.json.erb
Outdated
| @@ -20,7 +20,7 @@ | |||
| "proxy_password": null, | |||
| <% end %> | |||
| <% unless [nil, :undefined, :undef, ''].include?(scope['pulp::real_yum_max_speed']) -%> | |||
| "max_speed": <%= scope['pulp::real_yum_max_speed'] %>, | |||
| "max_speed": "<%= scope['pulp::real_yum_max_speed'] %>", | |||
There was a problem hiding this comment.
If pulp only understands bytes, this change should not be needed.
manifests/init.pp
Outdated
| @@ -186,7 +186,7 @@ | |||
| # | |||
| # $proxy_password:: Proxy password for authentication | |||
| # | |||
| # $yum_max_speed:: The maximum download speed for a Pulp task, such as a sync. (e.g. "4 Kb" or 1Gb") | |||
| # $yum_max_speed:: The maximum download speed for a Pulp task, such as a sync. (e.g. "4 kb" or 1gb") | |||
There was a problem hiding this comment.
to_bytes is weird. k[bB] is used, all the others use upper case prefixes: M[Bb] G[Bb] etc.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
chris1984
changed the title
|
@ekohl updated |
chris1984
changed the title
chris1984
changed the title
|
Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-pulp
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the init.pp description too since passing Kb fails with an error, as its the to bytes conversion is not happy with uppercase.