Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use provides, not the python package name for plugins #233

Merged
merged 3 commits into from Oct 20, 2021

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 19, 2021

@@ -3,10 +3,6 @@
# @api private
class pulpcore::install {

package { 'python3-pulpcore':
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl or should this "Provides: pulpcore"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you still want to explicitly install the package in case there is no plugin. I'd be happy with a Provides: pulpcore and then install pulpcore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no plugin, pulpcore won't start up 🤷‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I backed these out for now, as tests fail without 🤷‍♀️

@evgeni
Copy link
Member Author

evgeni commented Oct 19, 2021

currently failing because the provides aren't published yet, I'll re-kick once that happened

@evgeni evgeni force-pushed the provides branch 2 times, most recently from a818695 to b9baaf0 Compare October 19, 2021 15:50
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should mention this in https://github.com/theforeman/puppet-pulpcore#pulpcore-314. Other than that 👍

@evgeni evgeni merged commit e3d8f32 into theforeman:master Oct 20, 2021
@evgeni evgeni deleted the provides branch October 20, 2021 12:49
@ehelms ehelms added the Enhancement New feature or request label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants