With Puppet 4 data types we can simplify the complicated case statement
to a if/else.

This reverts commit 6cb7115.

closes GH-595

This reverts commit 0a45dd1.

This reverts commit 64b0cf3.

closes GH-609

Previously, `splaylimit` defaulted to a String and wouldn't accept
Integers.  `runinterval` defaulted to an Integer but wouldn't accept
Strings.

leaving it in breaks your puppet server setup

This change has already been made in foreman-installer-modulesync.

With recent versions of puppetlabs_spec_helper this is done automatically

This commit adds support to configure the
$confdir/custom_trusted_oid_mapping.yaml as described in
https://puppet.com/docs/puppet/5.5/config_file_oid_map.html.

Fixes GH-602.

By default, rspec-puppet-facts uses the facterdb facts that match the
version of the facter gem installed.  Starting with facter 3, facter
was no longer shipped as a gem (it was rewritten in C++).

This commit sets `facterversion` to `3.0.0` so that tests run with
more modern (structured) facts stubbed.

Puppet has been shipping facter 3 since puppet 4.2.0.  This module
supports puppet >= 4.6.1, (and puppet 4 is EOL at the end of 2018).

puppet-extlib's `ip_to_cron` function (used in
puppet::agent::service::cron) has recently moved to using the
`networking` structured fact not available in facter 2.

This is the current way of containing classes

Since 5.3.0 Puppet Server can use some gems shipped by puppet-agent. For
this the gem-path settings of puppetserver.conf needs to be extend by
/opt/puppetlabs/puppet/lib/ruby/vendor_gems. This is the default as
shipped by Puppetlabs.

Fixes GH-630.