Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes #2064 - manage puppetmaster if passenger is not used #27

Merged
merged 1 commit into from Jan 15, 2013

Conversation

Projects
None yet
2 participants
Owner

GregSutcliffe commented Dec 20, 2012

No description provided.

Member

domcleal commented Jan 11, 2013

Could we always include the module, but have ensure/enabled depend on the value of $passenger? It'd make it reliable when changing $passenger and puppet::server would be a little clearer then.

Owner

GregSutcliffe commented Jan 11, 2013

That shouldn't be too hard, just need to get the scoping right. Will fix it next week.

Owner

GregSutcliffe commented Jan 15, 2013

@domcleal done. Do you think I should move the subscribe into the service definition too? Can we just use ~> from server::config? I think that will ensure puppet::config too....

Member

domcleal commented Jan 15, 2013

@GregSutcliffe yep, a ~> between puppet::server::config and puppet::server::service will be fine. server config inherits config, so that should work and a notify against the class will notify its resources.

Owner

GregSutcliffe commented Jan 15, 2013

@domcleal done, over to you ;)

Member

domcleal commented Jan 15, 2013

My only nitpick is the require inside service.pp on the install class is redundant. Go ahead and merge if you get rid of it :)

Owner

GregSutcliffe commented Jan 15, 2013

Hah, was duplicating the puppet::service class, where it is also redundant :)

@GregSutcliffe GregSutcliffe merged commit 898cefa into theforeman:master Jan 15, 2013

@GregSutcliffe GregSutcliffe deleted the GregSutcliffe:2064 branch Jan 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment