New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #8278 - update foreman-prepare-realm for freeipa 4 #231
Conversation
|
To test this:
|
|
I also always run into this on fresh vm's, while |
|
Or if it's just for testing purposes: https://copr.fedoraproject.org/coprs/pviktori/breakmycryptod/ |
|
I am setting up to test this patch, will get back to that next week. |
| --permissions='modify services' --permissions='manage service keytab' --permission="read dns entries" \ | ||
| --permission="remove dns entries" --permission="add dns entries" --permission="update dns entries" | ||
|
|
||
| if [ "$PERMISSION_SYSTEM" -eq "v1"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space which is a shell parsing error. Also I don't understand numeric comparison of string. Can you ellaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to have
if [ "$PERMISSION_SYSTEM" == "v1" ]; then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean numeric comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know this is /bin/bash, but a single "=" is POSIX compatible, "==" is a bash-ism. I'll get my coat...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, I didn't realize -eq was different than ==, nor did I get this error when I ran it, strange. Thanks!
|
Ok finally I get to this, sorry for the delay. Was testing against F21 server on RHEL7 client which I added via |
| --permission='modify services' --permission='manage service keytab' --permission='read dns entries' \ | ||
| --permission='remove dns entries' --permission='add dns entries' --permission='update dns entries' | ||
| else | ||
| ipa permission-add 'Add Host Enrollment Password' --right='add' --type='host' --attrs='userpassword' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ipa client from RHEL7 does not understand the --right option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch, reverted back to permission then
|
Thanks @lzap, updated! |
|
You will also run into this on RHEL 7.0: https://bugzilla.redhat.com/show_bug.cgi?id=1122140 |
|
Ok this works fine on both RHEL6 and 7. |
|
Thank you for your contribution, merged as 2bd70b7. |
No description provided.