Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17069 - foreman-debug counts size instead lines #461

Conversation

Projects
None yet
5 participants
@pmoravec
Copy link

commented Sep 24, 2016

.. instead of tailing all (log)files

Update calling add_files (modified in foreman-debug).

Signed-off-by: Pavel Moravec pmoravec@redhat.com

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Sep 24, 2016

There were the following issues with the commit message:

  • length of the first commit message line for 50762ca exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@pmoravec pmoravec force-pushed the pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files branch from 50762ca to 0658751 Sep 24, 2016

@domcleal

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

Administrative note: this ticket is not from the Smart Proxy project, it's in Katello. Please file a ticket describing the changes in Smart Proxy. It also appears to depend on changes from theforeman/foreman#3881.

@pmoravec pmoravec force-pushed the pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files branch from 0658751 to 13e8a94 Oct 10, 2016

@pmoravec pmoravec force-pushed the pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files branch from 13e8a94 to 08c1288 Oct 12, 2016

@dmitri-d

This comment has been minimized.

Copy link
Member

commented Oct 24, 2016

Please see the administrative note above.

@pmoravec pmoravec force-pushed the pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files branch from 08c1288 to bb71988 Oct 24, 2016

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Oct 24, 2016

@pmoravec, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

  • Move ticket #16680 from Katello to the Smart Proxy project.
  • File a new ticket in the Smart Proxy project, update the PR title and the commit message (using git commit --amend).

This message was auto-generated by Foreman's prprocessor


# Puppet master and CA
add_files /var/lib/puppet/ssl/certs/$(hostname -f).pem /var/lib/puppet/ssl/certs/ca.pem
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/* /var/log/puppet/*.log*
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/*

This comment has been minimized.

Copy link
@dmitri-d

dmitri-d Oct 25, 2016

Member

These are locations for older versions of puppet (pre 4.0). Current versions use /etc/puppetlabs/*.

This comment has been minimized.

Copy link
@pmoravec

pmoravec Oct 25, 2016

Author

Can't upstream smart-proxy run with older puppet as well?

Anyway, I suggest filing new issue for this. Here in the PR I just reflect the planned change made to foreman-debug. My change does not bring a regression (I hope) and is independent on the puppet version / puppetlabs dir.


# Puppet master and CA
add_files /var/lib/puppet/ssl/certs/$(hostname -f).pem /var/lib/puppet/ssl/certs/ca.pem
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/* /var/log/puppet/*.log*
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/*
add_files /var/log/puppet/*.log*

This comment has been minimized.

Copy link
@dmitri-d

dmitri-d Oct 25, 2016

Member

Similarly, /var/log/puppetlabs and var/log/puppetserver directories are used by current versions of puppet.


# Puppet master and CA
add_files /var/lib/puppet/ssl/certs/$(hostname -f).pem /var/lib/puppet/ssl/certs/ca.pem
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/* /var/log/puppet/*.log*
add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/*
add_files /var/log/puppet/*.log*
add_files /etc/puppet/ssl/ca/inventory.txt /var/lib/puppet/ssl/ca/inventory.txt
add_cmd "find /etc/puppet/modules -exec ls -ld {} +" "puppet_manifests_tree"

This comment has been minimized.

Copy link
@dmitri-d

dmitri-d Oct 25, 2016

Member

Same issues as above.

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Oct 25, 2016

@pmoravec, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

  • Move ticket #16680 from Katello to the Smart Proxy project.
  • File a new ticket in the Smart Proxy project, update the PR title and the commit message (using git commit --amend).

This message was auto-generated by Foreman's prprocessor

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Oct 25, 2016

@pmoravec, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

  • Move ticket #16680 from Katello to the Smart Proxy project.
  • File a new ticket in the Smart Proxy project, update the PR title and the commit message (using git commit --amend).

This message was auto-generated by Foreman's prprocessor

Requested changes are better dealt with in a separate PR.

@dmitri-d dmitri-d changed the title Fixes #16680 - foreman-debug to collect whole newest (log)files .. Fixes #17069 - foreman-debug counts size instead lines Oct 26, 2016

@dmitri-d

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Waiting for theforeman/foreman#3881 to get merged.

Fixes #17069 - foreman-debug counts size instead lines
Update calling add_files (modified in foreman-debug).

Fixes #17069

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>

@pmoravec pmoravec force-pushed the pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files branch from bb71988 to e8ab8f8 Nov 8, 2016

@lzap lzap merged commit 2cc33ad into theforeman:develop Nov 8, 2016

1 check was pending

default You're not in the automated testing whitelist. Please contact us at #theforeman-dev to have this pull request manually tested.
Details
@lzap

This comment has been minimized.

Copy link
Member

commented Nov 8, 2016

Thanks, created ticket for the puppet paths: http://projects.theforeman.org/issues/17261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.