New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerdns to dns proxy #48

Closed
wants to merge 8 commits into
base: develop
from

Conversation

Projects
None yet
10 participants
@crazed
Copy link

crazed commented Dec 3, 2012

This works for basic PowerDNS functionality with MySQL as a backend

@ohadlevy

This comment has been minimized.

Copy link
Member

ohadlevy commented Dec 3, 2012

@crazed this is awesome! I'll try to review tomorrow, sadly I dont have access to powerdns instance, were you able to validate that it works on bind as well?

thanks!

@crazed

This comment has been minimized.

Copy link

crazed commented Dec 3, 2012

Thanks! No I couldn't test bind and didn't see any tests. I'm in the
opposite boat, no bind server to test with currently.
On Dec 3, 2012 1:38 PM, "Ohad Levy" notifications@github.com wrote:

@crazed https://github.com/crazed this is awesome! I'll try to review
tomorrow, sadly I dont have access to powerdns instance, were you able to
validate that it works on bind as well?

thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/48#issuecomment-10965338.

@anthonysomerset

This comment has been minimized.

Copy link

anthonysomerset commented Jan 7, 2013

I'm currently in the process of writing an interface to PointHQ for the smart-proxy for DNS, i think the whole ability to select different DNS providers is a great thing

at the moment to avoid later merge issues i'm somewhat held back by this pull request for the select DNS backend logic - is it possible that we could do a seperate pull request with just the first commit: crazed@18ccc00 to allow for further DNS smart-proxy services to be integrated

Merge pull request #1 from brianczapiga/add-powerdns-to-dns-proxy
adjust mysql query arguments to match modified variable names
@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Mar 5, 2013

You're not in the automated testing whitelist. Please contact us at #theforeman-dev to have this pull request manually reviewed and tested.

@lzap

This comment has been minimized.

Copy link
Member

lzap commented Jul 22, 2014

This needs a rebase, we changed smart proxy codebase to plugin architecture. Then @ohadlevy are you still able to review? :-)

@brianczapiga

This comment has been minimized.

Copy link

brianczapiga commented Jul 22, 2014

I'm working in a new environment with a bind server only. Trying to get PowerDNS installed as standard in this environment. Once done, I'll work on the plugin. :)

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 22, 2014

It may be interesting to know that 3.4 will have a REST API. See https://github.com/PowerDNS/pdnsapi for more information.

@dgagnon

This comment has been minimized.

Copy link

dgagnon commented Jul 24, 2014

Was this ever implemented using a plugin ?

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 25, 2014

@dgagnon No, this was written a long time before the smart-proxy ever had plugins.

@domcleal

This comment has been minimized.

Copy link
Contributor

domcleal commented Jul 10, 2015

The Smart Proxy's DNS module can now be extended by plugins, thanks to #7008. This would be a great way to start developing this feature if anybody's interested.

Here are some useful links:

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 10, 2015

Totally untested (and attribution): https://github.com/ekohl/smart_proxy_dns_powerdns

@dmitri-d

This comment has been minimized.

Copy link
Member

dmitri-d commented Jul 10, 2015

Haven’t looked at the code much, but this:
https://github.com/ekohl/smart_proxy_dns_powerdns/blob/master/lib/smart_proxy_dns_powerdns/dns_powerdns_main.rb#L33
is
open for sql injection…

-d

On Fri, Jul 10, 2015 at 3:58 PM, Ewoud Kohl van Wijngaarden <
notifications@github.com> wrote:

Totally untested (and attribution):
https://github.com/ekohl/smart_proxy_dns_powerdns


Reply to this email directly or view it on GitHub
#48 (comment)
.

@domcleal domcleal referenced this pull request Jul 10, 2015

Closed

Fix SQL injection #2

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 10, 2015

@witlessbird that was already present in the original code, but I agree and noticed it too.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Jul 18, 2015

https://github.com/theforeman/smart_proxy_dns_powerdns now exists so I think this can be closed.

@dmitri-d

This comment has been minimized.

Copy link
Member

dmitri-d commented Jul 18, 2015

closing, as a standalone plugin for power dns exists now: https://github.com/theforeman/smart_proxy_dns_powerdns

@dmitri-d dmitri-d closed this Jul 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment