This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
fix case matching issues in mac addresses #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this forces discovery_bootif.value to upper case when trying to match discovery_bootif to a macaddress_* fact. The macaddress_* facts generated by facter are always uppercase.
| @@ -130,7 +130,7 @@ def assign_host_to_hostgroup(discovered_host, hostgroup) | |||
|
|
|||
| interface = hosts_facts. | |||
| includes(:fact_name). | |||
| where(value: discovery_bootif.value). | |||
| where(value: discovery_bootif.value.upcase). | |||
|
ACK |
knowncitizen
added a commit
that referenced
this pull request
Jun 13, 2014
fix case matching issues in mac addresses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this forces mac addresses to lower case when trying to
match discovery_bootif to a macaddress_* fact.